Use std::isnan instead of self-comparison. #18021
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
resistor
reviewed
Mar 14, 2019
aten/src/ATen/native/Sorting.cpp
Outdated
| k - 1, | ||
| [](scalar_t x, scalar_t y) -> bool { | ||
| return ((x != x && y == y) || (x > y)); | ||
| return ((std::isnan(x) && !std::isnan(y)) || (x > y)); |
There was a problem hiding this comment.
Does this work correctly and efficiently when scalar_t is an integral type? I think this casts it to a double and still does a NaN check.
There was a problem hiding this comment.
Looks like you're right: https://godbolt.org/z/HhgWIu
There was a problem hiding this comment.
I believe you should be able to use numeric traits to test if scalar_t is a floating point type.
There was a problem hiding this comment.
It looks like someone already wrote a function do this, I'm going to use it.
|
LGTM |
|
But it doesn't work on Windows XD |
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 15, 2019
Summary: Pull Request resolved: pytorch/pytorch#18021 ghimport-source-id: 03423ba47ba5900c2b400c4457b148147ce8b35e Stack: * **#18021 Use std::isnan instead of self-comparison.** Signed-off-by: Edward Z. Yang <ezyang@fb.com> Reviewed By: soumith Differential Revision: D14460699 fbshipit-source-id: d8feb7f3f0e93996bd1b4f4aea163548b1d12437
|
This pull request has been merged in d3e3b24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D14460699