Move schema inference to c10 #18090
Closed
Move schema inference to c10 #18090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14491454 Differential Version: 75667663
This was referenced Mar 15, 2019
facebook-github-bot
added
the
oncall: jit
This was referenced Mar 15, 2019
dzhulgakov
approved these changes
Mar 18, 2019
Differential Revision: D14491454 Differential Version: 75960874
This was referenced Mar 19, 2019
Differential Revision: D14491454 Differential Version: 75964011
Differential Revision: D14491454 Differential Version: 76271259
Differential Revision: D14491454 Differential Version: 76377392
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 21, 2019
Summary: Pull Request resolved: pytorch/pytorch#18090 This schema inference is needed by the c10 operator registration mechanism. Move it to c10. It is going to be used by diffs stacked on top. Reviewed By: ezyang Differential Revision: D14491454 fbshipit-source-id: 0f8ddcdbd91467c8347d315dd443a1ca8b216481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #18038 Allow registering same operator schema multiple times 💚
:black_circle: #18090 Move schema inference to c10 💚
:white_circle: #18158 Allow using C10_DECLARE_TENSOR_TYPE and C10_DEFINE_TENSOR_TYPE from any namespace 💚
:white_circle: #18159 Fix use of c10::guts::apply 💚
:white_circle: #18160 Expose c10 operators to caffe2 by operator name 💛
:white_circle: #18161 New operator registration MVP 💚
:white_circle: #18162 Add functor- and function-based kernel registration API 💛
:white_circle: #18256 Check kernel against function schema in c10 op registration 💛
:white_circle: #18163 [wip] deprecated function based API 💛
This schema inference is needed by the c10 operator registration mechanism. Move it to c10.
It is going to be used by diffs stacked on top.
Differential Revision: D14491454