handle dst_bin_width==0 case properly #18240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14537668 fbshipit-source-id: 285158df61ba370e4f6cacf18671e07b7de410ce
Summary: For rare cases when dst_bin_width == 0 we should just put all numbers to an arbitrary bin. Differential Revision: D14544685 fbshipit-source-id: 11d6797955d6302c077bb0d47d7e6048cd85ebf1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For rare cases when dst_bin_width == 0 we should just put all numbers to an arbitrary bin.
Differential Revision: D14544685