Skip to content

[jit] Fix test on windows #18667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[jit] Fix test on windows #18667

wants to merge 1 commit into from

Conversation

driazati
Copy link
Contributor

Breakage in #18188

@driazati driazati mentioned this pull request Mar 31, 2019
Closed
@driazati driazati requested a review from ezyang March 31, 2019 18:20
facebook-github-bot
facebook-github-bot reviewed Mar 31, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@driazati merged this pull request in 3c70326.

@ezyang
Copy link
Contributor

ezyang commented Apr 1, 2019

This patch introduces a new segfault:

Apr 01 00:26:03 test_nn_InstanceNorm2d_tracking_stats (__main__.TestJitGeneratedModule) ... Traceback (most recent call last):
Apr 01 00:26:03   File "test/run_test.py", line 458, in <module>
Apr 01 00:26:03     main()
Apr 01 00:26:03   File "test/run_test.py", line 450, in main
Apr 01 00:26:03     raise RuntimeError(message)
Apr 01 00:26:03 RuntimeError: test_jit failed! Received signal: SIGSEGV

@suo suo mentioned this pull request Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@suo suo suo approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@driazati @facebook-github-bot @ezyang @suo