Enable gmock and fix system gtest issue #18706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14715302 Differential Version: 77672605
This was referenced Apr 1, 2019
Differential Revision: D14715302 Differential Version: 77673988
Differential Revision: D14715302 Differential Version: 77725327
ezyang
reviewed
Apr 2, 2019
|
This pull request has been merged in bb8a0d7. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 2, 2019
Summary: Pull Request resolved: pytorch/pytorch#18706 - Enable gmock - Fix issue where the gtest source files in third_party would include system gtest headers Reviewed By: ezyang Differential Revision: D14715302 fbshipit-source-id: 5335390913e651bda85c69d7ea9b5c1bce58f172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #18706 Enable gmock and fix system gtest issue 💛
:white_circle: #18547 Improve and test error messages for signature mismatches 💚
:white_circle: #18550 Improve compiler error messages of the op registration API 💚
:white_circle: #18551 Allow registering an operator schema without a kernel 💚
:white_circle: #18577 Register operators by passing arguments to RegisterOperators constructor 💚
:white_circle: #18592 [wip] Move ATen-core target one directory up 💛
:white_circle: #18593 [wip] Split function schema parser from operator 💛
:white_circle: #18594 [wip] Use function schema parser from op registration API 💛
:white_circle: #18597 [wip] Rewrite test cases with string based schema 💛
:white_circle: #18599 [wip] Use string based schema for exposing caffe2 ops 💛
:white_circle: #18600 [wip] Remove FunctionSchema based registration APIs 💛
Differential Revision: D14715302