Skip to content

Conversation

li-roy
Copy link
Contributor

@li-roy li-roy commented Apr 3, 2019

Stack from ghstack:

Removes tensorFromBlob() and puts equivalent functionality in at::from_blob().

Differential Revision: D14739335

Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
@li-roy li-roy requested review from ezyang and gchanan April 3, 2019 21:42
royboy added 2 commits April 3, 2019 21:39
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
stride *= sizes[i-1];
}
return strides;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate with this method in TensorImpl.h

  inline void update_to_contiguous_strides(size_t old_dim) {
    strides_.resize(sizes_.size(), 0);
    if (dim() > 0) {
      int last_idx = dim() - 1;
      strides_[last_idx] = 1;
      for (auto i = last_idx - 1; i >= 0; --i) {
        strides_[i] = strides_[i + 1] * std::max<int64_t>(sizes_[i + 1], 1);
      }
    }
    is_contiguous_ = true;
  }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the code existed from before. I'll accept the movement as long a we hide these methods in a private namespace (e.g., impl)

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo some naming comments.

royboy added 8 commits April 4, 2019 12:26
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
Remove tensorFromBlob() from Type

gh-metadata: pytorch pytorch 18779 gh/li-roy/2/head
zdevito pushed a commit to zdevito/ATen that referenced this pull request Apr 7, 2019
Summary:
Pull Request resolved: pytorch/pytorch#18779
ghimport-source-id: e7453b74fcce0e4f4a9cbce0324992a85272a426

Stack from [ghstack](https://github.com/ezyang/ghstack):
* #18780 Remove tensorWithAllocator() from Type
* **#18779 Remove tensorFromBlob() from Type**

Differential Revision: D14739335

fbshipit-source-id: 8a0619a5b412332efa3b2d60c1edebd53d089d50
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f6af76e.

facebook-github-bot pushed a commit that referenced this pull request Apr 8, 2019
Summary:
Pull Request resolved: #18780
ghimport-source-id: 7d18a11

Stack from [ghstack](https://github.com/ezyang/ghstack):
* **#18780 Remove tensorWithAllocator() from Type**
* #18779 Remove tensorFromBlob() from Type

Differential Revision: D14739336

fbshipit-source-id: 429ab10bb9f6ac9f97b5a11c7a836b6b6336cb2d
zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this pull request May 6, 2019
Summary:
Pull Request resolved: pytorch#18779
ghimport-source-id: e7453b7

Stack from [ghstack](https://github.com/ezyang/ghstack):
* pytorch#18780 Remove tensorWithAllocator() from Type
* **pytorch#18779 Remove tensorFromBlob() from Type**

Differential Revision: D14739335

fbshipit-source-id: 8a0619a5b412332efa3b2d60c1edebd53d089d50
zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this pull request May 6, 2019
Summary:
Pull Request resolved: pytorch#18780
ghimport-source-id: 7d18a11

Stack from [ghstack](https://github.com/ezyang/ghstack):
* **pytorch#18780 Remove tensorWithAllocator() from Type**
* pytorch#18779 Remove tensorFromBlob() from Type

Differential Revision: D14739336

fbshipit-source-id: 429ab10bb9f6ac9f97b5a11c7a836b6b6336cb2d
@ezyang ezyang deleted the gh/li-roy/2/head branch May 30, 2019 15:16
lezcano added a commit that referenced this pull request Nov 3, 2021
`at::defaultStride` was added in
#18779
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See
#18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Nov 3, 2021
…Stride"

`at::defaultStride` was added in
#18779
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See
#18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 10, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 14, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 15, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 15, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 19, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 19, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 21, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 21, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 22, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 22, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 22, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 22, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 22, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 22, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 28, 2021
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Dec 28, 2021
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jan 3, 2022
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jan 3, 2022
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jan 4, 2022
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jan 4, 2022
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jan 5, 2022
…ement of defaultStride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jan 5, 2022
…Stride"


`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Differential Revision: [D32684852](https://our.internmc.facebook.com/intern/diff/D32684852)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jan 6, 2022
)

Summary:
Pull Request resolved: #67789

`at::defaultStride` was added in #18779.
As it was noted in that PR, it differs from the actual computation of
the default strides when one or more of the dimensions of the tensor are
zero. See #18779 (comment)

We add two functions, `contiguous_strides` and `contiguous_strides_vec`
which correct this issue and we replace the previous (wrong) uses of
`defaultStride`.

cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D32684852

Pulled By: mruberry

fbshipit-source-id: 62997a5a97a4241a12e73e2be2e192b80b491cb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants