Make it possible for users for select /Zi or /ZI over /Z7 when using MSVC #18790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 3, 2019
…MSVC (#18790) Summary: Fixes pytorch/pytorch#18701. Pull Request resolved: pytorch/pytorch#18790 Differential Revision: D14748195 Pulled By: ezyang fbshipit-source-id: e50df1b5ca199a88d7b5ea3ea45d25d23cd31a27
peterjc123
added a commit
to peterjc123/pytorch
that referenced
this pull request
Apr 12, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 12, 2019
Summary: Pull Request resolved: #19187 Differential Revision: D14913100 Pulled By: ezyang fbshipit-source-id: bf147747f933a2c9a35f3ff00bf6b83a4f29286c
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19187 Differential Revision: D14913100 Pulled By: ezyang fbshipit-source-id: bf147747f933a2c9a35f3ff00bf6b83a4f29286c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18701.