Skip to content

[jit] Only require python print on certain namespaces #18846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

[jit] Only require python print on certain namespaces #18846

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
24e1193
[jit] Only require python print on certain namespaces
bwasti Apr 4, 2019
d4020e7
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 5, 2019
64a8590
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 11, 2019
27c6060
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 11, 2019
b8823b5
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 11, 2019
1ebb9e7
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 11, 2019
33c5c81
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 11, 2019
8bec3ff
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 12, 2019
ee39b7c
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 12, 2019
1592876
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 16, 2019
6ae8c09
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 16, 2019
7574c56
Update on "[jit] Only require python print on certain namespaces"
bwasti Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion torch/csrc/jit/passes/python_print.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,16 @@ TORCH_API bool printerHasSpecialCaseFor(Symbol sym) {

};

return handled.count(sym) || unneeded.count(sym);
// These namespaces are required to have Python printers unless
// otherwise noted in unneeded.
const static std::unordered_set<Symbol> required_namespaces = {
c10::namespaces::prim,
c10::namespaces::aten,
c10::namespaces::onnx,
};

return handled.count(sym) || unneeded.count(sym) ||
!required_namespaces.count(sym.ns());
}

} // namespace jit
Expand Down