Add ScalarType argument to Type::options() #19270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
li-roy
requested review from
ezyang,
gchanan and
smessmer
and removed request for
ebetica,
goldsborough and
yf225
added 2 commits
April 15, 2019 23:41
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
smessmer
approved these changes
Apr 16, 2019
added 5 commits
April 17, 2019 16:10
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
|
Type::options() is not considered public API, right? Great work btw!!! |
added 5 commits
April 18, 2019 12:39
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
Add ScalarType argument to Type::options() gh-metadata: pytorch pytorch 19270 gh/li-roy/9/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 22, 2019
Summary: Pull Request resolved: pytorch/pytorch#19270 ghimport-source-id: a5ade6131f3260066c5750ea1fa9ed5c998bb791 Differential Revision: D14938707 Pulled By: li-roy fbshipit-source-id: 018fb3f01706531a06515d6d861e5683a455a705
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19270 ghimport-source-id: a5ade61 Differential Revision: D14938707 Pulled By: li-roy fbshipit-source-id: 018fb3f01706531a06515d6d861e5683a455a705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Since Type will now be dtype agnostic, we need to add a scalar type argument to fill options.
Differential Revision: D14938707