-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Allow registering ops without specifying the full schema #19286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Differential Revision: D14931921 Differential Version: 79493183
Differential Revision: D14931921 Differential Version: 79547652
Differential Revision: D14931921 Differential Version: 79570169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty idiomatic :)
Given that you just check whether '(' is in the schema - couldn't we just use str.find() first and then call one method or another? That way we could have saved ourselves need for Either.
But since you've already added it, I don't mind
Differential Revision: D14931921 Differential Version: 79580377
|
We'd still need the either type because - even if using |
Differential Revision: D14931921 Differential Version: 79637869
|
This pull request has been merged in 5ca22cc. |
Summary: Pull Request resolved: pytorch/pytorch#19286 The operator registration API now allows registering an operator by only giving the operator name and not the full operator schema, as long as the operator schema can be inferred from the kernel function. Reviewed By: dzhulgakov Differential Revision: D14931921 fbshipit-source-id: 3776ce43d4ce67bb5a3ea3d07c37de96eebe08ba
Summary: Pull Request resolved: pytorch#19286 The operator registration API now allows registering an operator by only giving the operator name and not the full operator schema, as long as the operator schema can be inferred from the kernel function. Reviewed By: dzhulgakov Differential Revision: D14931921 fbshipit-source-id: 3776ce43d4ce67bb5a3ea3d07c37de96eebe08ba
Stack:
:white_circle: #19280 Split function schema parser from operator 💛
:white_circle: #19281 Fixing function schema parser for Android 💛
:white_circle: #19282 Move function schema parser to ATen/core build target 💚
:white_circle: #19283 String-based schemas in op registration API 💛
:white_circle: #19284 Allow ops without tensor args if only fallback kernel exists 💛
:white_circle: #19285 Add either type 💛
:black_circle: #19286 Allow registering ops without specifying the full schema 💛
:white_circle: #19287 Use string based schema for exposing caffe2 ops 💛
:white_circle: #19288 Add some tests 💛
:white_circle: #19289 Optional inputs and outputs 💛
:white_circle: #19290 Add tests for argument types 💛
The operator registration API now allows registering an operator by only giving the operator name and not the full operator schema,
as long as the operator schema can be inferred from the kernel function.
Differential Revision: D14931921