[pt1][quant] Add print function for QTensor #19513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D15017168 Differential Version: 80137572
jerryzh168
force-pushed
the
export-D15017168
branch
from
638be5e to
99f8911
Compare
pytorchbot
added
module: operators
module: printing
gchanan
requested changes
Apr 22, 2019
Differential Revision: D15017168 Differential Version: 80438721
|
@gchanan can you review again |
Differential Revision: D15017168 Differential Version: 80637260
gchanan
requested changes
Apr 24, 2019
|
@gchanan for printing both, I don't have a strong reason for it, mostly just assuming user might want to see both of them since they both represents the values that the QTensor contains. |
Differential Revision: D15017168 Differential Version: 80772826
|
@gchanan could you review again? |
gchanan
reviewed
May 2, 2019
gchanan
reviewed
May 2, 2019
gchanan
reviewed
May 2, 2019
gchanan
reviewed
May 2, 2019
Differential Revision: D15017168 Differential Version: 81115670
Differential Revision: D15017168 Differential Version: 81115796
Differential Revision: D15017168 Differential Version: 81115973
gchanan
reviewed
May 2, 2019
Differential Revision: D15017168 Differential Version: 81122150
Differential Revision: D15017168 Differential Version: 81180808
Differential Revision: D15017168 Differential Version: 81199014
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch/pytorch#19513 Add support for printing a QTensor in python frontend Differential Revision: D15017168 fbshipit-source-id: 312d1f18e6ca3c9eb4a5b8bb1c64f7cc8bc1dcf5
|
This pull request has been merged in 17268a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #19513 [pt1][quant] Add print function for QTensor 💚
Add support for printing a QTensor in python frontend
Differential Revision: D15017168