Fix compilation on Windows 10 (CUDA 10.0, Visual Studio 2017) #19615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
approved these changes
Apr 23, 2019
|
Seems like the last test was successful as well but Github's status couldn't be updated. |
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
…h#19615) Summary: I want to use libtorch in a C++/CUDA project but as soon as I include `<torch/torch.h>`, ".cu" files fail to compile: `torch/csrc/jit/script/tree.h(64): error C3520: 'args': parameter pack must be expanded in this context` This PR makes it build on my machine (don't know if it breaks anything though). Pull Request resolved: pytorch#19615 Differential Revision: D15063712 Pulled By: ezyang fbshipit-source-id: 7561e705f8f5b42b8e6a23430710b36508fee1ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use libtorch in a C++/CUDA project but as soon as I include
<torch/torch.h>, ".cu" files fail to compile:torch/csrc/jit/script/tree.h(64): error C3520: 'args': parameter pack must be expanded in this contextThis PR makes it build on my machine (don't know if it breaks anything though).