-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Update foxi version #19793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update foxi version #19793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to block the fix to land but .DS_Store shouldn't be committed. We should probably add it to .gitignore.
@yinghai it's in there, not sure why it's changed |
Looks like it needs to be removed from git also |
we need to update the foxi, and update the submodule again |
@zrphercule merged this pull request in c182824. |
Summary: Update foxi to the latest version for group quantization. Pull Request resolved: pytorch#19793 Reviewed By: jackm321, houseroad Differential Revision: D15095982 Pulled By: zrphercule fbshipit-source-id: 0d1cb403cbda47a4fda9035e1712fced60ced283
Update foxi to the latest version for group quantization.