Skip to content

Conversation

zrphercule
Copy link
Contributor

Update foxi to the latest version for group quantization.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@jackm321 jackm321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

Copy link
Contributor

@yinghai yinghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block the fix to land but .DS_Store shouldn't be committed. We should probably add it to .gitignore.

@jackm321
Copy link
Contributor

@yinghai it's in there, not sure why it's changed

@jackm321
Copy link
Contributor

Looks like it needs to be removed from git also

@zrphercule
Copy link
Contributor Author

@yinghai @jackm321 Let's merge this first to unbreak master, and remove it using another pr, since this one has been landing for a while now.

@houseroad
Copy link
Member

we need to update the foxi, and update the submodule again

@facebook-github-bot
Copy link
Contributor

@zrphercule merged this pull request in c182824.

@zrphercule zrphercule deleted the fix_foxi branch April 29, 2019 23:26
zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this pull request May 6, 2019
Summary:
Update foxi to the latest version for group quantization.
Pull Request resolved: pytorch#19793

Reviewed By: jackm321, houseroad

Differential Revision: D15095982

Pulled By: zrphercule

fbshipit-source-id: 0d1cb403cbda47a4fda9035e1712fced60ced283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants