Forbid kernels from returning Scalar[] #19811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D15101924 Differential Version: 80804448
pytorchbot
added
the
module: internals
dzhulgakov
approved these changes
Apr 30, 2019
|
This pull request has been merged in c6cb32f. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#19811 This does not immediately take effect for the custom op API but will break backwards compatibility once we switch to the new operator registration. Reviewed By: dzhulgakov Differential Revision: D15101924 fbshipit-source-id: 8890a5a3e163d3263dc1837be0b4851984771917
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19811 This does not immediately take effect for the custom op API but will break backwards compatibility once we switch to the new operator registration. Reviewed By: dzhulgakov Differential Revision: D15101924 fbshipit-source-id: 8890a5a3e163d3263dc1837be0b4851984771917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #19811 Forbid kernels from returning Scalar[] 💛
This does not immediately take effect for the custom op API but will break backwards compatibility once we switch to the new operator registration.
Differential Revision: D15101924