Break circular dependency between Type.h, Tensor.h and TensorMethods.h #19830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these headers always include each other. Not only it creates a different behavior depending on which header was included first, it also creates a false sense of selective including - i.e. one might think they only include Type-related code, but in fact they also always include Tensor.h and TensorMethods.h.
pytorchbot
added
the
module: internals
Closed
zdevito
approved these changes
Apr 29, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 29, 2019
…h (#19830) Summary: Pull Request resolved: pytorch/pytorch#19830 ghimport-source-id: 9b057c549652a39d6706679ee86494124bb40ef0 Differential Revision: D15115631 Pulled By: ZolotukhinM fbshipit-source-id: 821c0aedacd9692d6076349ff8318c8f6234891c
|
@ZolotukhinM merged this pull request in 1146444. |
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
pytorch#19830) Summary: Pull Request resolved: pytorch#19830 ghimport-source-id: 9b057c5 Differential Revision: D15115631 Pulled By: ZolotukhinM fbshipit-source-id: 821c0aedacd9692d6076349ff8318c8f6234891c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Currently these headers always include each other. Not only it creates a
different behavior depending on which header was included first, it also creates
a false sense of selective including - i.e. one might think they only include
Type-related code, but in fact they also always include Tensor.h and
TensorMethods.h.
Differential Revision: D15115631