Allow Dict type in c10 operators #20184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D15227620 Differential Version: 81263199
Differential Revision: D15227620 Differential Version: 81264823
Differential Revision: D15227620 Differential Version: 81279546
li-roy
approved these changes
May 7, 2019
Differential Revision: D15227620 Differential Version: 81330636
Differential Revision: D15227620 Differential Version: 81395865
Differential Revision: D15227620 Differential Version: 81401249
Differential Revision: D15227620 Differential Version: 81416435
Differential Revision: D15227620 Differential Version: 81423410
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 9, 2019
Summary: Pull Request resolved: pytorch/pytorch#20184 - Add support for Dict<Key, Value> arguments and returns to c10 operators - Add support for std::unordered_map<Key, Value> to the legacy API (but not to c10 kernels) Reviewed By: li-roy Differential Revision: D15227620 fbshipit-source-id: c1ea6c12165e07b74272cb48c6021bdb5c2d7922
|
This pull request has been merged in e0166f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #20185 Extend testAvailableArgTypes 💚
:black_circle: #20184 Allow Dict type in c10 operators 💚
:white_circle: #19976 Dict 💚
Differential Revision: D15227620