Skip to content

Remove SourceLocation (respin) #20333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove SourceLocation (respin) #20333

wants to merge 1 commit into from

Conversation

zdevito
Copy link
Contributor

@zdevito zdevito commented May 9, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D15284081

@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: build Build system issues module: internals Related to internal abstractions in c10 and ATen module: onnx Related to torch.onnx module: pybind Related to our Python bindings / interactions with other Python libraries labels May 9, 2019
wanchaol
wanchaol approved these changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zou3519 zou3519 deleted the gh/zdevito/39/head branch May 9, 2019 23:19
zdevito added a commit to zdevito/ATen that referenced this pull request May 10, 2019
@zdevito @facebook-github-bot
Remove SourceLocation (respin) (#20333)
dfbf9bb 
Summary:
Pull Request resolved: pytorch/pytorch#20333
ghimport-source-id: e64075bb82067224463e9955d10bd13967d1975d

Differential Revision: D15284081

Pulled By: zdevito

fbshipit-source-id: ac26ae48392b9daff08f460529c06af8f4e4722a
@facebook-github-bot
Copy link
Contributor

@zdevito merged this pull request in 3afd996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanchaol wanchaol wanchaol approved these changes

Assignees

No one assigned

Labels

Merged module: build Build system issues module: internals Related to internal abstractions in c10 and ATen module: onnx Related to torch.onnx module: pybind Related to our Python bindings / interactions with other Python libraries oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zdevito @facebook-github-bot @wanchaol @pytorchbot @mruberry