Add documentation to Dispatch.h #20339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also reordered the macros so the deprecated ones are all at the end. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
pytorchbot
added
the
module: internals
Add documentation to Dispatch.h I also reordered the macros so the deprecated ones are all at the end. Signed-off-by: Edward Z. Yang <ezyang@mit.edu> gh-metadata: pytorch pytorch 20339 gh/ezyang/127/head
izdeby
approved these changes
May 10, 2019
| // DEPRECATED MACROS, DON'T USE THESE | ||
| // ---------------------------------------------------------------------------- | ||
|
|
||
| #define AT_DISPATCH_ALL_TYPES_AND_HALF(TYPE, NAME, ...) \ |
There was a problem hiding this comment.
I dont think these two are being used anywhere. can we just kill them?
There was a problem hiding this comment.
You're the expert on this :) IIRC, we weren't allowed to remove them because external code might be using them.
|
Love this change! |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 10, 2019
Summary: Pull Request resolved: pytorch/pytorch#20339 ghimport-source-id: 99b6cf9f03be8d55674a43c8a7e19a42b75143f1 Differential Revision: D15295652 Pulled By: ezyang fbshipit-source-id: f3b127ed3f53f13931596c06e181056940443290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I also reordered the macros so the deprecated ones are all
at the end.
Signed-off-by: Edward Z. Yang ezyang@mit.edu
Differential Revision: D15295652