fix a couple of typos in README markdown #20819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: docs
ezyang
approved these changes
May 23, 2019
cpuhrsch
reviewed
May 23, 2019
| frontend: | ||
| a) For an inplace operations such as `self.abs_()` | ||
| frontend: | ||
| a) For an inplace operations such as `self.abs_()` |
There was a problem hiding this comment.
There's some extra white space at the end of this line.
There was a problem hiding this comment.
It's intentional, two whitespace characters cause the rendering to break to the next line. Otherwise it puts the a) and b) sections all on one line, which looks kind of messy. You can see what it looks like on master here:
https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/README.md
cpuhrsch
approved these changes
May 23, 2019
There was a problem hiding this comment.
@nairbv is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 23, 2019
Summary: was reading the README on github and came across a couple of typos. Pull Request resolved: pytorch/pytorch#20819 Differential Revision: D15469603 Pulled By: nairbv fbshipit-source-id: 0ed7868de2d4e6d82557a8c170783966f8a1afd7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was reading the README on github and came across a couple of typos.