Skip to content

Fix unused variable warning #21444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix unused variable warning #21444

wants to merge 1 commit into from

Conversation

@asuhan
Copy link
Contributor

@asuhan asuhan commented Jun 6, 2019

No description provided.

@pytorchbot pytorchbot added the module: internals Related to internal abstractions in c10 and ATen label Jun 6, 2019
@ailzhang ailzhang requested review from ailzhang and smessmer June 6, 2019 01:21
fmassa
fmassa reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use C10_UNUSED instead?

pytorch/c10/macros/Macros.h

Lines 87 to 91 in c25e337

#ifdef _MSC_VER
#define C10_UNUSED
#else
#define C10_UNUSED __attribute__((__unused__))
#endif //_MSC_VER

This is by the way how we do it in Dispatch.h

pytorch/aten/src/ATen/Dispatch.h

Lines 17 to 19 in adbab82

const auto& UNDERLYING_TYPE C10_UNUSED = underlying_enum; \
using scalar_t C10_UNUSED = type; \
using underlying_t C10_UNUSED = underlying_type; \

ezyang
ezyang reviewed Jun 6, 2019
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jun 7, 2019
@asuhan @facebook-github-bot
Fix unused variable warning
ac88327 
Summary: Pull Request resolved: pytorch/pytorch#21444

Differential Revision: D15701786

Pulled By: ezyang

fbshipit-source-id: 8348e08f9b8f3047b30736f9a944786ab84e6b68
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in abc0d3e.

@vishwakftw vishwakftw mentioned this pull request Jun 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@fmassa fmassa fmassa left review comments

@ezyang ezyang ezyang approved these changes

@smessmer smessmer Awaiting requested review from smessmer

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees

No one assigned

Labels

Merged module: internals Related to internal abstractions in c10 and ATen open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@asuhan @facebook-github-bot @ezyang @fmassa @pytorchbot @mruberry