[jit] Split out Function into its own file #21539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some preparatory movement to prepare for the CU ownership overhaul. Changes are purely mechanical.
pytorchbot
added
caffe2
oncall: jit
zdevito
approved these changes
Jun 10, 2019
Krovatkin
approved these changes
Jun 10, 2019
| struct CAFFE2_API FunctionType : public Type { | ||
| static FunctionTypePtr create( | ||
| std::shared_ptr<torch::jit::script::Function> function) { | ||
| std::shared_ptr<torch::jit::Function> function) { |
There was a problem hiding this comment.
yes, thought I might as well start now :)
torch/csrc/jit/function.h
Outdated
| mutable std::unique_ptr<FunctionSchema> schema_; | ||
| }; | ||
| } // namespace jit | ||
| } // namespace torch No newline at end of file |
torch/csrc/jit/function.cpp
Outdated
| check_single_output(); | ||
| } | ||
| } // namespace jit | ||
| } // namespace torch No newline at end of file |
[jit] Split out Function into its own file Some preparatory movement to prepare for the CU ownership overhaul. Changes are purely mechanical. gh-metadata: pytorch pytorch 21539 gh/suo/57/head
[jit] Split out Function into its own file Some preparatory movement to prepare for the CU ownership overhaul. Changes are purely mechanical. gh-metadata: pytorch pytorch 21539 gh/suo/57/head
[jit] Split out Function into its own file Some preparatory movement to prepare for the CU ownership overhaul. Changes are purely mechanical. gh-metadata: pytorch pytorch 21539 gh/suo/57/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 11, 2019
Summary: Pull Request resolved: pytorch/pytorch#21539 ghimport-source-id: f1e4396a0bec6e30d3179f926ec4da68807942f7 Differential Revision: D15741979 Pulled By: suo fbshipit-source-id: 4cd0ed36bcbf8db0b36a101dda6f58975f806889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some preparatory movement to prepare for the CU ownership overhaul.
Changes are purely mechanical.
Differential Revision: D15741979