Further remove redundant CMake option passing code for those CMake variables that are directly controlled by environment variables but with a different name. #22154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables that are directly controlled by environment variables but with a different name.
ezyang
reviewed
Jun 24, 2019
| '_GLIBCXX_USE_CXX11_ABI': 'GLIBCXX_USE_CXX11_ABI', | ||
| 'MKL_SEQ': 'INTEL_MKL_SEQUENTIAL', | ||
| 'MKL_TBB': 'INTEL_MKL_TBB', | ||
| 'USE_CUDA_STATIC_LINK': 'CAFFE2_STATIC_LINK_CUDA' |
There was a problem hiding this comment.
Sigh. Our build system really is outrageous XD
ezyang
approved these changes
Jun 24, 2019
|
This and co all waiting on CI |
…se CMake variables that are directly controlled by environment variables but with a different name." Further remove redundant CMake option passing code for those CMake variables that are directly controlled by environment variables but with a different name. gh-metadata: pytorch pytorch 22154 gh/xuhdev/5/head
|
Updated to resolve a newly developed conflict in master |
…se CMake variables that are directly controlled by environment variables but with a different name." Further remove redundant CMake option passing code for those CMake variables that are directly controlled by environment variables but with a different name. gh-metadata: pytorch pytorch 22154 gh/xuhdev/5/head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is done by making
additional_optionsa dict rather than a set.Differential Revision: D15985376