Rename copy_tensor_data to copy_tensor_metadata #22266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: internals
|
Thanks! Btw does this make more sense to make it |
gchanan
approved these changes
Jun 26, 2019
yf225
force-pushed
the
rename_copy_tensor_data
branch
from
dc8a5c9 to
78cb4cc
Compare
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ailzhang
approved these changes
Jun 26, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 27, 2019
Summary: The original name `copy_tensor_data` could be confusing because users are not sure whether it deep-copies data in the tensor's storage or just copies the tensor's metadata. The renaming makes it more clear. cc. ailzhang This might break XLA build, but I think the renaming makes it more clear why we use `copy_tensor_data` in XLATensorImpl's shallow-copy functions. Pull Request resolved: pytorch/pytorch#22266 Differential Revision: D16014724 Pulled By: yf225 fbshipit-source-id: f6ee966927d4d65d828b68264b3253b2f8fd768d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original name
copy_tensor_datacould be confusing because users are not sure whether it deep-copies data in the tensor's storage or just copies the tensor's metadata. The renaming makes it more clear.cc. @ailzhang This might break XLA build, but I think the renaming makes it more clear why we use
copy_tensor_datain XLATensorImpl's shallow-copy functions.