EraseNumberTypes cleans itself up #22461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D16094656 Differential Version: 85966345
This was referenced Jul 2, 2019
|
This pull request has been merged in 830c659. |
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#22461 We shouldn't call dead code elimination after EraseNumberTypes because dead code elimination assumes a valid jit graph which EraseNumberTypes just broke. Let's have it clean up itself isntead. Reviewed By: houseroad Differential Revision: D16094656 fbshipit-source-id: f2752277d764e78ab276c57d56b2724b872b136f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #22239 Open up AliasAnalysisKind for any ops 💛
:white_circle: #22175 AliasAnalysisKind::CONSERVATIVE/FROM_SCHEMA 💛
:white_circle: #22476 Fix dead code elimination in onnx export 💛
:black_circle: #22461 EraseNumberTypes cleans itself up 💚
We shouldn't call dead code elimination after EraseNumberTypes because dead code elimination assumes a valid jit graph which EraseNumberTypes just broke.
Let's have it clean up itself isntead.
Differential Revision: D16094656