Skip to content

Quantized conv avoid functional usage #22733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 18 commits into from
Closed

Quantized conv avoid functional usage #22733

wants to merge 18 commits into from

Conversation

@z-a-f
Copy link

@z-a-f z-a-f commented Jul 11, 2019 •
edited
Loading

Stack:
    :black_circle:  #22733 Quantized conv avoid functional usage  💚

This refactor changes the conv module to avoid the usage of the functional ops.

Differential Revision: D15835572

V8: Fixed a bug where we pass packed input to the conv2d function
2d5ff06 
Differential Revision: D15835572
Differential Version: 86310356
@pytorchbot pytorchbot added the module: nn Related to torch.nn label Jul 11, 2019
@z-a-f z-a-f force-pushed the export-D15835572 branch from 1653c75 to 2d5ff06 Compare July 11, 2019 05:50
@z-a-f
Copy link
Author

z-a-f commented Jul 11, 2019 •
edited
Loading

Something went terribly wrong. THe old patch (#21808) got corrupted -- created this one instead.

@z-a-f z-a-f mentioned this pull request Jul 11, 2019
Closed
V9: Rebase
bd52894 
Differential Revision: D15835572
Differential Version: 86310782
jerryzh168
jerryzh168 reviewed Jul 11, 2019
View reviewed changes
jerryzh168
jerryzh168 reviewed Jul 11, 2019
View reviewed changes
jerryzh168
jerryzh168 reviewed Jul 11, 2019
View reviewed changes
jerryzh168
jerryzh168 approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

zaf added 3 commits July 11, 2019 14:25
V10: Merge with parent diff changes
467ad50 
Differential Revision: D15835572
Differential Version: 86351016
V12: (no description)
1f0d89b 
Differential Revision: D15835572
Differential Version: 86365519
V1: Resubmitting
e75878b 
Differential Revision: D16234314
Differential Version: 86435522
raghuramank100
raghuramank100 reviewed Jul 14, 2019
View reviewed changes
raghuramank100
raghuramank100 approved these changes Jul 14, 2019
View reviewed changes
Copy link
Contributor

@raghuramank100 raghuramank100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a request for a follow up task, please address

zaf added 5 commits July 15, 2019 15:41
V4: Rebase and skip tests
7e593c7 
Differential Revision: D16234314
Differential Version: 86524852
V5: Documentation fix
dcea2b4 
Differential Revision: D16234314
Differential Version: 86525194
V6: (no description)
85354ef 
Differential Revision: D16234314
Differential Version: 86525441
V7: (no description)
50005da 
Differential Revision: D16234314
Differential Version: 86529536
V13: Rebase
7a93f04 
Differential Revision: D15835572
Differential Version: 86532606
@z-a-f z-a-f changed the base branch from master to export-D16234314 July 15, 2019 23:58
@z-a-f z-a-f mentioned this pull request Jul 15, 2019
Closed
V14: Rebase before land
f5f1927 
Differential Revision: D15835572
Differential Version: 86690114
@z-a-f z-a-f changed the base branch from export-D16234314 to master July 17, 2019 19:08
zaf added 4 commits July 18, 2019 18:49
V18: Merge with parent diff changes
8af29a7 
Differential Revision: D15835572
Differential Version: 86803347
V19: Rebase
107ceb7 
Differential Revision: D15835572
Differential Version: 86837148
V20: Merge with parent diff changes
cda6dc2 
Differential Revision: D15835572
Differential Version: 86886465
V21: Conflict resolution
7800739 
Differential Revision: D15835572
Differential Version: 86910090
zaf added 3 commits July 23, 2019 12:05
V22: Fixed rebase errors
faa8e9e 
Differential Revision: D15835572
Differential Version: 87023790
V23: (no description)
31d30cf 
Differential Revision: D15835572
Differential Version: 87029298
V24: Fix contamination
8d57545 
Differential Revision: D15835572
Differential Version: 87065943
@ezyang ezyang deleted the export-D15835572 branch July 24, 2019 19:31
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 94711d7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

+1 more reviewer

@raghuramank100 raghuramank100 raghuramank100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: nn Related to torch.nn

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@z-a-f @facebook-github-bot @jerryzh168 @raghuramank100 @pytorchbot @mruberry