[jit] Make classtypes hold a weak_ptr to their CU #22902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks the ownership cycle between modules and their functions.
pytorchbot
added
oncall: jit
This was referenced Jul 16, 2019
zdevito
approved these changes
Jul 16, 2019
jamesr66a
approved these changes
Jul 16, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 16, 2019
Summary: Pull Request resolved: pytorch/pytorch#22902 Test Plan: Imported from OSS Differential Revision: D16278159 Pulled By: suo fbshipit-source-id: 6aa682e347847e808b44218d38ff1dae66945a07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
load()create only one CU #22727 [jit] Makeload()create only one CUThis breaks the ownership cycle between modules and their functions.
Differential Revision: D16278159