Skip to content

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Jul 16, 2019

Stack from ghstack:

Differential Revision: D16467985

@gchanan gchanan changed the title Dont allow conversions with QInt. Introduce AT_FORALL_QINTS Jul 26, 2019
@gchanan gchanan requested a review from jerryzh168 July 26, 2019 16:09

AT_FORALL_SCALAR_TYPES_WITH_COMPLEX_EXCEPT_COMPLEX_HALF(DEFINE_CAST)
AT_FORALL_SCALAR_TYPES_WITH_COMPLEX_EXCEPT_COMPLEX_HALF_AND_QINT(DEFINE_CAST)
AT_FORALL_QINTS(DEFINE_CAST)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to cast them to quint8* or uint8*?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel uint8* might be more useful for people

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, I think that's the correct solution but outside of the scope of this PR, which is just trying to rationalize the AT_FORALL macros. So I'm just trying to match up with this one:

#define AT_DISPATCH_QINT_TYPES(TYPE, NAME, ...) \
[&] { \
const auto& SCALAR_TYPE C10_UNUSED = TYPE; \
switch (TYPE) { \
AT_QINT_PRIVATE_CASE_TYPE( \
at::kQInt8, at::qint8, at::kChar, int8_t, __VA_ARGS__) \
AT_QINT_PRIVATE_CASE_TYPE( \
at::kQUInt8, at::quint8, at::kByte, uint8_t, __VA_ARGS__) \
AT_QINT_PRIVATE_CASE_TYPE( \
at::kQInt32, at::qint32, at::kInt, int, __VA_ARGS__) \
default: \
AT_ERROR(#NAME, " not implemented for '", toString(TYPE), "'"); \
} \
}()

so I should have actually called this AT_FORALL_QINT_TYPES, but I fix that up in a later PR in this stack.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed #23440 for addressing that.

Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zou3519 zou3519 deleted the gh/gchanan/30/head branch July 26, 2019 21:48
@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in 953459f.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 26, 2019
Summary: Pull Request resolved: pytorch/pytorch#22931

Test Plan: Imported from OSS

Differential Revision: D16467985

Pulled By: gchanan

fbshipit-source-id: 3925fc96a641e66b92fa65c542a2a23190c915a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: internals Related to internal abstractions in c10 and ATen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants