[ONNX] fix the CI job for onnx #22946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: build
bddppq
reviewed
Jul 16, 2019
scripts/onnx/test.sh
Outdated
| pip install ninja --user | ||
| # ninja is installed in /var/lib/jenkins/.local/bin | ||
|
|
||
| # JIT C++ extensions require ninja, and put it into PATH. |
bddppq
reviewed
Jul 16, 2019
.jenkins/caffe2/test.sh
Outdated
| ##################### | ||
| if [[ "$BUILD_ENVIRONMENT" == *onnx* ]]; then | ||
| pip install -q --user git+https://github.com/pytorch/vision.git | ||
| pip install --user ninja |
bddppq
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad merged this pull request in b96610b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX uses virtualenv, and PyTorch doesn't. So --user flag is causing problems in ONNX ci...
Fixing it by moving it to pytorch only scripts. And will install ninja in onnx ci separately.