Switch from KaTeX to imgmath for documentation rendering. #23025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emprically, KaTeX is bad user experience for users who don't have powerful CPUs. With x4 CPU slowdown emulation in Chrome, I notice that imgmath takes a third of the time to render than KaTeX. This requires pytorch/pytorch_sphinx_theme#48 to be landed first, as otherwise the style sheet renders img incorrectly. Might be one step on the way to solving #20984. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
pytorchbot
added
the
module: docs
ezyang
added a commit
that referenced
this pull request
Jul 18, 2019
Emprically, KaTeX is bad user experience for users who don't have powerful CPUs. With x4 CPU slowdown emulation in Chrome, I notice that imgmath takes a third of the time to render than KaTeX. This requires pytorch/pytorch_sphinx_theme#48 to be landed first, as otherwise the style sheet renders img incorrectly. Might be one step on the way to solving #20984. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: f20be2b Pull Request resolved: #23025
zou3519
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Emprically, KaTeX is bad user experience for users who don't have
powerful CPUs. With x4 CPU slowdown emulation in Chrome, I notice
that imgmath takes a third of the time to render than KaTeX.
This requires pytorch/pytorch_sphinx_theme#48 to
be landed first, as otherwise the style sheet renders img incorrectly.
Might be one step on the way to solving #20984.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D16441000