Fix load op to return the shape info as before when loading multiple blobs #23166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blobs Summary: Changing the load op to take in shapes vector needs changes in lots of places (almost all usages of load op). Instead this is a small and safe change where the behavior is unchanged if we are loading multiple blobs and when loading a single blob without shape information. If you are loading just one blob and the shape information is provided, then this returns the right shape info back. For all other cases, behavior is unchanged as before we introduced the issue. This fixes the issue reported by Andrey in D16229465 Differential Revision: D16390551 fbshipit-source-id: 790b8c4bcbff48b94d5ec3318ad611ff6dfdccdf
pradeepd24
force-pushed
the
export-D16390551
branch
from
b8da586 to
a2de154
Compare
|
This pull request has been merged in fd90b96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changing the load op to take in shapes vector needs changes in lots of places (almost all usages of load op).
Instead this is a small and safe change where the behavior is unchanged if we are loading multiple blobs and when loading a single blob without shape information.
If you are loading just one blob and the shape information is provided, then this returns the right shape info back.
For all other cases, behavior is unchanged as before we introduced the issue.
This fixes the issue reported by Andrey in D16229465
Differential Revision: D16390551