Skip to content

[ONNX] Update ONNX docs #23185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[ONNX] Update ONNX docs #23185

wants to merge 4 commits into from

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jul 22, 2019 •
edited
Loading

This is still work in progress.

There are several more items to add to complete this doc, including

  • LHS indexing, index assignments.
  • Tensor List.
  • Shape/Type propagation.
  • FAQs

Please review and share your thoughts, feel free to add anything that you think should be included as well. @houseroad @spandantiwari @lara-hdr @neginraoof

@pytorchbot pytorchbot added module: docs Related to our documentation, both in docs/ and docblocks module: onnx Related to torch.onnx labels Jul 22, 2019
@houseroad houseroad self-requested a review July 24, 2019 15:57
facebook-github-bot
facebook-github-bot reviewed Jul 24, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad reviewed Jul 24, 2019
View reviewed changes
houseroad
houseroad reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After first glance, I think the content is pretty good! Great thanks! will find some time to get a more thorough review. Let's target landing this before the release cut :-)

cc: @jspisak @soumith

houseroad
houseroad reviewed Jul 24, 2019
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@BowenBao BowenBao changed the title [WIP][ONNX] Update ONNX docs [ONNX] Update ONNX docs Jul 26, 2019
houseroad
houseroad approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

facebook-github-bot
facebook-github-bot reviewed Jul 26, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 46224ef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks module: onnx Related to torch.onnx open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BowenBao @facebook-github-bot @houseroad @ezyang @pytorchbot @mruberry