Use concrete types in jit test for generic lists #23192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating an untyped generic list is deprecated, we always want type information to be present. This fixes test cases and removes one that used lists with ambigious types. Differential Revision: [D16431482](https://our.internmc.facebook.com/intern/diff/D16431482/)
smessmer
added a commit
that referenced
this pull request
Jul 22, 2019
Creating an untyped generic list is deprecated, we always want type information to be present. This fixes test cases and removes one that used lists with ambigious types. Differential Revision: [D16431482](https://our.internmc.facebook.com/intern/diff/D16431482/) ghstack-source-id: 86972891 Pull Request resolved: #23192
zdevito
approved these changes
Jul 23, 2019
|
This pull request has been merged in 2073cc7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Creating an untyped generic list is deprecated, we always want type information to be present.
This fixes test cases and removes one that used lists with ambigious types.
Differential Revision: D16431482