Rename torch::autograd::Function to torch::autograd::Node #23269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
malvika2147
requested review from
apaszke,
ebetica,
goldsborough,
mrshenli,
pietern and
yf225
as code owners
pytorchbot
added
module: autograd
facebook-github-bot
added
the
oncall: jit
malvika2147
changed the title
malvika2147
changed the title
Stack from [ghstack](https://github.com/ezyang/ghstack): * **#23269 Rename torch::autograd::Function to torch::autograd::Node** Summary: We will be adding an API for custom autograd functions in C++ (#23020) and we would like to expose it as `torch::autograd::Function` (which is different from the current `torch::autograd::Function`) to match the Python API. So, I plan to rename the current `torch::autograd::Function` to `torch::autograd::Node` and `torch::autograd::PyFunction` to `torch::autograd::PyNode`. Planned updates to this stack: 1. Rename `PyFunction` to `PyNode` 2. Rename `FunctionTask`, and `deleteFunction` to `NodeTask`, `deleteNode` for consistency.
ezyang
approved these changes
Jul 23, 2019
|
This pull request has been merged in e7a9b0d. |
|
@ezyang FYI the PR summary didn't end up in the commit. Perhaps some race. But the summary here is very valuable for anyone casually reading the code and figuring out what motivated this change. |
|
I let the open source team know about that; I see that the diff has the correct description and so ShipIt ought to have preserved it. |
|
Is there any reason we didn't rename "function.h" and "function.cpp" to "node.h" and "node.cpp"? It will certainly make folks reading the code in the future a bit easier. |
|
Laziness, probably :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
We will be adding an API for custom autograd functions in C++ (#23020) and we would like to expose it as
torch::autograd::Function(which is different from the currenttorch::autograd::Function) to match the Python API. So, I plan to rename the currenttorch::autograd::Functiontotorch::autograd::Nodeandtorch::autograd::PyFunctiontotorch::autograd::PyNode.FunctionTask, anddeleteFunctionrenamed toNodeTask,deleteNodefor consistency.Differential Revision: D16454878