Whether MKLDNN should be built under native arch should respect USE_NATIVE_ARCH #23445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ATIVE_ARCH Currently there is no way to build MKLDNN more optimized than sse4. This commit let MKLDNN build respect USE_NATIVE_ARCH.
|
LGTM. @gujinghui or @XiaobingSuper could you review? I'll merge in a little bit if you don't have time. |
|
If highlight in cmake/Summary.cmake and define in CMakeLists.txt as an dependent option, will be perfect to me. |
I didn't define another build option because |
|
OK. I see it in below line. Good to me. Pls go ahread. |
ezyang
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 29, 2019
…ATIVE_ARCH (#23445) Summary: Currently there is no way to build MKLDNN more optimized than sse4. This commit let MKLDNN build respect USE_NATIVE_ARCH. Pull Request resolved: pytorch/pytorch#23445 Differential Revision: D16542275 Pulled By: ezyang fbshipit-source-id: 550976531d6a52db9128c0e3d4589a33715feee2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to build MKLDNN more optimized than sse4. This commit let MKLDNN build respect USE_NATIVE_ARCH.