Add TORCH_CHECK to disable sub for bool tensors #23519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cpu
|
Same as #23335 , but corrected error message for bool-bool |
gchanan
requested changes
Jul 29, 2019
gchanan
reviewed
Jul 29, 2019
xuhdev
force-pushed
the
sub-dispatch
branch
2 times, most recently
from
d7ac7d1 to
660a2da
Compare
This resolves two issues in one shot: - sub shouldn't be available for bool type. - When sub is applied to an unsupported type, the current error messages shows "add_cpu/add_cuda is not implemented for [type]". They should be "sub_cpu/sub_cuda" instead.
|
@gchanan This PR should be ready now |
gchanan
approved these changes
Jul 29, 2019
|
thanks @xuhdev! |
|
@izdeby can you handle landing this? I don't know if there are complications with the other Boolean--related PRs you are working on. |
There was a problem hiding this comment.
@izdeby has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thank you all for your review! |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 30, 2019
Summary: This resolves two issues in one shot: - sub shouldn't be available for bool type. - When sub is applied to an unsupported type, the current error messages shows "add_cpu/add_cuda is not implemented for [type]". They should be "sub_cpu/sub_cuda" instead. Pull Request resolved: pytorch/pytorch#23519 Differential Revision: D16548770 Pulled By: izdeby fbshipit-source-id: fe404a2a97b8d11bd180ec41364bf8e68414fb15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves two issues in one shot:
shows "add_cpu/add_cuda is not implemented for [type]". They should be
"sub_cpu/sub_cuda" instead.