Allow types as node attributes #26268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2019
This was referenced Sep 19, 2019
suo
approved these changes
Sep 23, 2019
This was referenced Sep 24, 2019
Allow types as node attributes This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. gh-metadata: pytorch pytorch 26268 gh/zdevito/108/head
Allow types as node attributes This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. gh-metadata: pytorch pytorch 26268 gh/zdevito/108/head
Allow types as node attributes This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. gh-metadata: pytorch pytorch 26268 gh/zdevito/108/head
Allow types as node attributes This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. gh-metadata: pytorch pytorch 26268 gh/zdevito/108/head
Allow types as node attributes This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. gh-metadata: pytorch pytorch 26268 gh/zdevito/108/head
Allow types as node attributes This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. gh-metadata: pytorch pytorch 26268 gh/zdevito/108/head
Allow types as node attributes This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. gh-metadata: pytorch pytorch 26268 gh/zdevito/108/head
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#26268 This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. Test Plan: Imported from OSS Differential Revision: D17412855 Pulled By: zdevito fbshipit-source-id: 7a2618c8a9f9dfc94858af79afbf433518eda4b3
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26268 This is necessary to represent operators like isinstance where the type needs to be recorded in the node. This diff does not actually use the attributes for anything yet. One plausible thing to do in the future would be use attributes to fill in the values of type variables for nodes whose schema include type variables rather than rematching them from the arguments. However, this change is not required for isinstance so I have left it for later. Test Plan: Imported from OSS Differential Revision: D17412855 Pulled By: zdevito fbshipit-source-id: 7a2618c8a9f9dfc94858af79afbf433518eda4b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is necessary to represent operators like isinstance where
the type needs to be recorded in the node.
This diff does not actually use the attributes for anything yet.
One plausible thing to do in the future would be use attributes to
fill in the values of type variables for nodes whose schema include
type variables rather than rematching them from the arguments. However,
this change is not required for isinstance so I have left it for later.
Differential Revision: D17412855