Skip to content

Port GatedLinearUnit forward to TensorIterator. #26687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Port GatedLinearUnit forward to TensorIterator. #26687

wants to merge 5 commits into from

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Sep 23, 2019 •
edited
Loading

Stack from ghstack:

This involves:

  1. Porting GatedLinearUnit CPU from ATen to TensorIterator
  2. Porting GatedLinearUnit CUDA from THNN to TensorIterator.

Differential Revision: D17539477

@gchanan
Port GatedLinearUnit forward to TensorIterator.
b616c5f 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.
@pytorchbot pytorchbot added module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: operators labels Sep 23, 2019
@gchanan gchanan mentioned this pull request Sep 23, 2019
Closed
gchanan added a commit that referenced this pull request Sep 23, 2019
@gchanan
Port GatedLinearUnit forward to TensorIterator.
4b7a4d6 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

ghstack-source-id: ea5e263
Pull Request resolved: #26687
@gchanan
Update on "Port GatedLinearUnit forward to TensorIterator."
c7edbff 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

Differential Revision: [D17539477](https://our.internmc.facebook.com/intern/diff/D17539477)
gchanan added a commit that referenced this pull request Sep 24, 2019
@gchanan
Port GatedLinearUnit forward to TensorIterator.
d9dd610 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

ghstack-source-id: 1bfb35d
Pull Request resolved: #26687
VitalyFedyunin
VitalyFedyunin approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@VitalyFedyunin VitalyFedyunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach before/after benchmark numbers.

@gchanan
Copy link
Contributor Author

gchanan commented Sep 24, 2019

I'm trying to use a new benchmark system, so benchmarks might take a bit longer than the usual timeit.

@gchanan
Update on "Port GatedLinearUnit forward to TensorIterator."
6e38068 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

Differential Revision: [D17539477](https://our.internmc.facebook.com/intern/diff/D17539477)
gchanan added a commit that referenced this pull request Oct 13, 2019
@gchanan
Port GatedLinearUnit forward to TensorIterator.
3f39256 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

ghstack-source-id: 8431fb7
Pull Request resolved: #26687
@XiaobingSuper
Copy link
Collaborator

#24571 Migrate glu from the TH to Aten (CUDA)
#24572 Migrate glu_backward from the TH to Aten (CUDA)
#24707 Migrate glu from the TH to Aten (CPU)
#24708 Migrate glu_backward from the TH to Aten (CPU)

@XiaobingSuper
Copy link
Collaborator

@gchanan. do you have any progress about it?

@gchanan gchanan mentioned this pull request Feb 11, 2020
Closed
@gchanan
Update on "Port GatedLinearUnit forward to TensorIterator."
b11b010 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

Differential Revision: [D17539477](https://our.internmc.facebook.com/intern/diff/D17539477)

[ghstack-poisoned]
gchanan added a commit that referenced this pull request Feb 11, 2020
@gchanan
Port GatedLinearUnit forward to TensorIterator.
76e559b 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

ghstack-source-id: 3a407fa
Pull Request resolved: #26687
@dr-ci
Copy link

dr-ci bot commented Feb 11, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 33e48a3:

Commit 33e48a3 was recently pushed. Waiting for builds...

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 3 times.

@gchanan
Update on "Port GatedLinearUnit forward to TensorIterator."
33e48a3 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

Differential Revision: [D17539477](https://our.internmc.facebook.com/intern/diff/D17539477)

[ghstack-poisoned]
gchanan added a commit that referenced this pull request Feb 13, 2020
@gchanan
Port GatedLinearUnit forward to TensorIterator.
2d1df6a 
This involves:
1) Porting GatedLinearUnit CPU from ATen to TensorIterator
2) Porting GatedLinearUnit CUDA from THNN to TensorIterator.

ghstack-source-id: 3098f19
Pull Request resolved: #26687
@facebook-github-bot facebook-github-bot deleted the gh/gchanan/88/head branch August 13, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@VitalyFedyunin VitalyFedyunin VitalyFedyunin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gchanan @XiaobingSuper @VitalyFedyunin @facebook-github-bot @pytorchbot