Skip to content

Conversation

jamesr66a
Copy link
Collaborator

@jamesr66a jamesr66a commented Sep 27, 2019

Stack from ghstack:

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Differential Revision: D17641765

@pytorchbot pytorchbot added module: operators oncall: quantization Quantization support in PyTorch labels Sep 27, 2019
jamesr66a pushed a commit that referenced this pull request Sep 27, 2019
ghstack-source-id: d791b46
Pull Request resolved: #27002
@jamesr66a jamesr66a requested a review from jianyuh September 27, 2019 22:47
Copy link
Member

@jianyuh jianyuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

jianyuh added a commit that referenced this pull request Sep 27, 2019
Similar to #27002, we want to save some overhead.

Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/)

[ghstack-poisoned]
jianyuh added a commit that referenced this pull request Sep 27, 2019
Similar to #27002, we want to save some overhead.

Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/)

ghstack-source-id: 90963482
Pull Request resolved: #27005
@jamesr66a jamesr66a added this to the 1.3 milestone Sep 27, 2019
@facebook-github-bot
Copy link
Contributor

@jamesr66a merged this pull request in cca3a36.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 28, 2019
Summary:
Pull Request resolved: pytorch/pytorch#27002

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Test Plan: Imported from OSS

Differential Revision: D17641765

Pulled By: jamesr66a

fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jianyuh added a commit that referenced this pull request Sep 30, 2019
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/)
jianyuh added a commit that referenced this pull request Sep 30, 2019
…some overhead"

Similar to #27002, we want to save some overhead.

Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Oct 1, 2019
Summary:
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 1, 2019
Summary:
Pull Request resolved: pytorch/pytorch#27005

Similar to pytorch/pytorch#27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
jamesr66a pushed a commit that referenced this pull request Oct 3, 2019
Summary:
Pull Request resolved: #27002

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Test Plan: Imported from OSS

Differential Revision: D17641765

Pulled By: jamesr66a

fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jamesr66a pushed a commit that referenced this pull request Oct 3, 2019
Summary:
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
jamesr66a pushed a commit that referenced this pull request Oct 3, 2019
Summary:
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
jamesr66a pushed a commit that referenced this pull request Oct 3, 2019
Summary:
Pull Request resolved: #27002

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Test Plan: Imported from OSS

Differential Revision: D17641765

Pulled By: jamesr66a

fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jamesr66a pushed a commit that referenced this pull request Oct 3, 2019
Summary:
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
jamesr66a pushed a commit that referenced this pull request Oct 4, 2019
Summary:
Pull Request resolved: #27002

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Test Plan: Imported from OSS

Differential Revision: D17641765

Pulled By: jamesr66a

fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jamesr66a pushed a commit that referenced this pull request Oct 4, 2019
Summary:
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
jamesr66a pushed a commit that referenced this pull request Oct 4, 2019
Summary:
Pull Request resolved: #27002

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Test Plan: Imported from OSS

Differential Revision: D17641765

Pulled By: jamesr66a

fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jamesr66a pushed a commit that referenced this pull request Oct 4, 2019
Summary:
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
soumith pushed a commit that referenced this pull request Oct 7, 2019
Summary:
Pull Request resolved: #27002

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Test Plan: Imported from OSS

Differential Revision: D17641765

Pulled By: jamesr66a

fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
soumith pushed a commit that referenced this pull request Oct 7, 2019
Summary:
Pull Request resolved: #27005

Similar to #27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
@facebook-github-bot facebook-github-bot deleted the gh/jamesr66a/116/head branch October 28, 2019 22:14
pdlive215 pushed a commit to pdlive215/pytorch that referenced this pull request Nov 27, 2019
Summary:
Pull Request resolved: pytorch#27002

This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)

Test Plan: Imported from OSS

Differential Revision: D17641765

Pulled By: jamesr66a

fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
pdlive215 pushed a commit to pdlive215/pytorch that referenced this pull request Nov 27, 2019
…7005)

Summary:
Pull Request resolved: pytorch#27005

Similar to pytorch#27002, we want to save some overhead.
ghstack-source-id: 91046563

Test Plan: CI

Differential Revision: D17641819

fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: quantization Quantization support in PyTorch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants