-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[quantization] Dont zero out buffers in dynamic linear #27002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianyuh
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing this!
jianyuh
added a commit
that referenced
this pull request
Sep 27, 2019
Similar to #27002, we want to save some overhead. Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/) [ghstack-poisoned]
jianyuh
added a commit
that referenced
this pull request
Sep 27, 2019
Similar to #27002, we want to save some overhead. Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/) ghstack-source-id: 90963482 Pull Request resolved: #27005
@jamesr66a merged this pull request in cca3a36. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 28, 2019
Summary: Pull Request resolved: pytorch/pytorch#27002 This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model) Test Plan: Imported from OSS Differential Revision: D17641765 Pulled By: jamesr66a fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jianyuh
added a commit
that referenced
this pull request
Sep 30, 2019
Pull Request resolved: #27005 Similar to #27002, we want to save some overhead. ghstack-source-id: 91046563 Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/)
jianyuh
added a commit
that referenced
this pull request
Sep 30, 2019
…some overhead" Similar to #27002, we want to save some overhead. Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/) [ghstack-poisoned]
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 1, 2019
Summary: Pull Request resolved: pytorch/pytorch#27005 Similar to pytorch/pytorch#27002, we want to save some overhead. ghstack-source-id: 91046563 Test Plan: CI Differential Revision: D17641819 fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27002 This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model) Test Plan: Imported from OSS Differential Revision: D17641765 Pulled By: jamesr66a fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27002 This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model) Test Plan: Imported from OSS Differential Revision: D17641765 Pulled By: jamesr66a fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #27002 This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model) Test Plan: Imported from OSS Differential Revision: D17641765 Pulled By: jamesr66a fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #27002 This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model) Test Plan: Imported from OSS Differential Revision: D17641765 Pulled By: jamesr66a fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
soumith
pushed a commit
that referenced
this pull request
Oct 7, 2019
Summary: Pull Request resolved: #27002 This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model) Test Plan: Imported from OSS Differential Revision: D17641765 Pulled By: jamesr66a fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#27002 This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model) Test Plan: Imported from OSS Differential Revision: D17641765 Pulled By: jamesr66a fbshipit-source-id: b0ef30767eec9774fc503bb51fed039222026bba
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…7005) Summary: Pull Request resolved: pytorch#27005 Similar to pytorch#27002, we want to save some overhead. ghstack-source-id: 91046563 Test Plan: CI Differential Revision: D17641819 fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This was taking a significant amount of time in my benchmarks with larger output sizes (e.g. final output projection in a language classification model)
Differential Revision: D17641765