Add control for observers in Fake-quantize module #27113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected Differential Revision: [D17678875](https://our.internmc.facebook.com/intern/diff/D17678875/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 30, 2019
Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected Differential Revision: [D17678875](https://our.internmc.facebook.com/intern/diff/D17678875/) ghstack-source-id: 91071181 Pull Request resolved: #27113
dzhulgakov
approved these changes
Oct 1, 2019
| def enable_observer(mod): | ||
| if type(mod) == FakeQuantize: | ||
| mod.disable_observer() | ||
| mod.enable_observer() |
There was a problem hiding this comment.
This is why we need tests for every single line of code change :-)
|
@pytorchbot retest this please |
|
This pull request has been merged in 9e3ba35. |
This was referenced Oct 2, 2019
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27113 Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected ghstack-source-id: 91071181 Test Plan: buck test mode/dev-nosan caffe2/test:fake_quant -- test_fake_quant_control Differential Revision: D17678875 fbshipit-source-id: 2912ad8b6e674daa1d129f7a7c6f27d8c1b4f93b
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27113 Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected ghstack-source-id: 91071181 Test Plan: buck test mode/dev-nosan caffe2/test:fake_quant -- test_fake_quant_control Differential Revision: D17678875 fbshipit-source-id: 2912ad8b6e674daa1d129f7a7c6f27d8c1b4f93b
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27113 Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected ghstack-source-id: 91071181 Test Plan: buck test mode/dev-nosan caffe2/test:fake_quant -- test_fake_quant_control Differential Revision: D17678875 fbshipit-source-id: 2912ad8b6e674daa1d129f7a7c6f27d8c1b4f93b
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #27113 Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected ghstack-source-id: 91071181 Test Plan: buck test mode/dev-nosan caffe2/test:fake_quant -- test_fake_quant_control Differential Revision: D17678875 fbshipit-source-id: 2912ad8b6e674daa1d129f7a7c6f27d8c1b4f93b
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #27113 Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected ghstack-source-id: 91071181 Test Plan: buck test mode/dev-nosan caffe2/test:fake_quant -- test_fake_quant_control Differential Revision: D17678875 fbshipit-source-id: 2912ad8b6e674daa1d129f7a7c6f27d8c1b4f93b
soumith
pushed a commit
that referenced
this pull request
Oct 7, 2019
Summary: Pull Request resolved: #27113 Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected ghstack-source-id: 91071181 Test Plan: buck test mode/dev-nosan caffe2/test:fake_quant -- test_fake_quant_control Differential Revision: D17678875 fbshipit-source-id: 2912ad8b6e674daa1d129f7a7c6f27d8c1b4f93b
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#27113 Fix bug in fake quant control of observer and fake-quantize operations. Add test to ensure that features work as expected ghstack-source-id: 91071181 Test Plan: buck test mode/dev-nosan caffe2/test:fake_quant -- test_fake_quant_control Differential Revision: D17678875 fbshipit-source-id: 2912ad8b6e674daa1d129f7a7c6f27d8c1b4f93b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix bug in fake quant control of observer and fake-quantize operations.
Add test to ensure that features work as expected
Differential Revision: D17678875