[quant][graphmode][fix] Don't permute in quantized::conv2d pattern #27347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 3, 2019
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
approved these changes
Oct 25, 2019
I'll add a single conv test, we don't have that yet. |
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182919](https://our.internmc.facebook.com/intern/diff/D18182919) [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182919](https://our.internmc.facebook.com/intern/diff/D18182919) [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182919](https://our.internmc.facebook.com/intern/diff/D18182919) [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182919](https://our.internmc.facebook.com/intern/diff/D18182919) [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182919](https://our.internmc.facebook.com/intern/diff/D18182919) [ghstack-poisoned]
… pattern" Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182919](https://our.internmc.facebook.com/intern/diff/D18182919) [ghstack-poisoned]
|
This pull request has been merged in 59c5de4. |
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
Summary: it's already done in the op, we don't need to permute again Test Plan: test_jit.py we'll test in e2e tests Reviewers: mvz Subscribers: Tasks: Tags: ghstack-source-id: 416e0c4 Pull Request resolved: pytorch/pytorch#27347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
it's already done in the op, we don't need to permute again
Test Plan:
test_jit.py
we'll test in e2e tests
Reviewers:
mvz
Subscribers:
Tasks:
Tags:
Differential Revision: D18182919