Skip to content

Run clang-format for torch/distributed/rpc #27531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Run clang-format for torch/distributed/rpc #27531

wants to merge 6 commits into from

Conversation

@pietern
Copy link
Contributor

@pietern pietern commented Oct 8, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D17808206

@pietern pietern requested a review from mrshenli as a code owner October 8, 2019 10:00
@pytorchbot pytorchbot added oncall: distributed Add this issue/PR to distributed oncall triage queue module: pybind Related to our Python bindings / interactions with other Python libraries labels Oct 8, 2019
This was referenced Oct 8, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@pietern pietern mentioned this pull request Oct 8, 2019
Closed
pietern added a commit that referenced this pull request Oct 8, 2019
@pietern
Run clang-format for torch/distributed/rpc
7e85061 
ghstack-source-id: 2c4d540
Pull Request resolved: #27531
mrshenli
mrshenli approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp the changes on format change, but this PR needs a rebase to update message types.

@pietern pietern mentioned this pull request Oct 9, 2019
Closed
pietern added a commit that referenced this pull request Oct 9, 2019
@pietern
Run clang-format for torch/distributed/rpc
2923e5b 
ghstack-source-id: ed1a950
Pull Request resolved: #27531
@pietern pietern added the module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer label Oct 9, 2019
pietern added a commit that referenced this pull request Oct 29, 2019
@pietern
Run clang-format for torch/distributed/rpc
7f259c3 
ghstack-source-id: 311adf4
Pull Request resolved: #27531
pietern added a commit that referenced this pull request Nov 4, 2019
@pietern
Run clang-format for torch/distributed/rpc
12cd380 
ghstack-source-id: 5b83bfe
Pull Request resolved: #27531
@pietern
Copy link
Contributor Author

pietern commented Nov 5, 2019

The commit that's landing has a fix for the build failures in the most recent commit in this PR.

@facebook-github-bot
Copy link
Contributor

@pietern merged this pull request in 49fba35.

@facebook-github-bot facebook-github-bot deleted the gh/pietern/53/head branch November 8, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

Assignees

No one assigned

Labels

Merged module: pybind Related to our Python bindings / interactions with other Python libraries module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pietern @facebook-github-bot @mrshenli @pytorchbot @mruberry