Add std::variant backport (mpark) as c10::variant, with gcc 7.3.1 fix #27575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2019 14:41
This reverts commit 7e95b89.
pytorchbot
added
module: build
yf225
force-pushed
the
mpark_variant_with_fix
branch
from
fc34438 to
365db0e
Compare
|
What are the workarounds? |
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 9, 2019
… (#27575) Summary: This is the same as pytorch/pytorch#26836 with workarounds for gcc 7.3.1 bug in light of pytorch/pytorch#27277 (comment). The workaround also limits the use cases of `c10::variant`, but it is sufficient for our (simple) use case. Pull Request resolved: pytorch/pytorch#27575 Differential Revision: D17834410 Pulled By: yf225 fbshipit-source-id: e8f3c0be2904ec3d2975cbb80af237a5c9d0cb92
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
…pytorch#27575) Summary: This is the same as pytorch#26836 with workarounds for gcc 7.3.1 bug in light of pytorch#27277 (comment). The workaround also limits the use cases of `c10::variant`, but it is sufficient for our (simple) use case. Pull Request resolved: pytorch#27575 Differential Revision: D17834410 Pulled By: yf225 fbshipit-source-id: e8f3c0be2904ec3d2975cbb80af237a5c9d0cb92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #26836 with workarounds for gcc 7.3.1 bug in light of #27277 (comment). The workaround also limits the use cases of
c10::variant, but it is sufficient for our (simple) use case.