Mark sampler and batch_sampler arguments as optional in the DataLoader interface #27821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DataLoader interface
pytorchbot
added
module: dataloader
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
…r interface (pytorch#27821) Summary: Changelog: - DataLoader argument `sampler` is now of type `Optional[Sampler[int]]`instead of `Sampler[int]` - DataLoader argument `batch_sampler` is now of type `Optional[Sampler[Sequence[int]]]` instead of `Sampler[Sequence[int]]` Fixes pytorch#27737 Pull Request resolved: pytorch#27821 Differential Revision: D17906623 Pulled By: ezyang fbshipit-source-id: 088cacbb7e9f7988995f40b71adc3e719815f5ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
sampleris now of typeOptional[Sampler[int]]instead ofSampler[int]batch_sampleris now of typeOptional[Sampler[Sequence[int]]]instead ofSampler[Sequence[int]]Fixes #27737