Skip to content

Migrate remaining ops to the c10 dispatcher #27978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

Migrate remaining ops to the c10 dispatcher #27978

wants to merge 18 commits into from

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Oct 15, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D17929697

@smessmer smessmer mentioned this pull request Oct 15, 2019
Closed
smessmer added a commit that referenced this pull request Oct 15, 2019
@smessmer
Migrate remaining ops to the c10 dispatcher
d6e7a9a 
-

Differential Revision: [D17929697](https://our.internmc.facebook.com/intern/diff/D17929697/)

ghstack-source-id: 91928420
Pull Request resolved: #27978
This was referenced Oct 17, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@smessmer smessmer requested review from dzhulgakov and ezyang October 17, 2019 00:19
@smessmer smessmer mentioned this pull request Oct 17, 2019
Closed
ezyang
ezyang approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be clear guidance about when to specify unboxed_only or not.

@ezyang
Copy link
Contributor

ezyang commented Oct 17, 2019

I've been talking to people who were confused by these options. I think we should probably just write an algorithm to detect patterns that are not supported automatically, and then infer in this way.

ezyang
ezyang requested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACKing test breakage

@dzhulgakov
Copy link
Collaborator

Agree with Ed - is it something we can figure out automatically by parsing schemas?

At the very least - if unboxed_only is the new default, why not just omit it? Any change to native_functions is pretty disturbing because of merge conflicts and mental overhead.

@smessmer
Copy link
Contributor Author

@dzhulgakov see #28187 which removes it

@smessmer smessmer requested a review from ezyang October 21, 2019 22:16
@smessmer
Copy link
Contributor Author

@ezyang Test failures should be fixed

@smessmer smessmer requested a review from apaszke as a code owner October 22, 2019 07:11
dzhulgakov
dzhulgakov approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@dzhulgakov dzhulgakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging the two PRs

@smessmer smessmer mentioned this pull request Oct 22, 2019
Closed
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8de8cab.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 24, 2019
@smessmer @facebook-github-bot
Migrate remaining ops to the c10 dispatcher (#27978)
f540ce8 
Summary:
Pull Request resolved: pytorch/pytorch#27978

-
ghstack-source-id: 92469187

Test Plan: waitforsandcastle

Differential Revision: D17929697

fbshipit-source-id: 01f4f67cd676c719d9d1fb13bdd43aca3dfa1c8a
@facebook-github-bot facebook-github-bot deleted the gh/smessmer/74/head branch October 28, 2019 22:20
@ezyang ezyang mentioned this pull request Nov 1, 2019
Closed
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
@smessmer
Migrate remaining ops to the c10 dispatcher (pytorch#27978)
00eb1bd 
Summary:
Pull Request resolved: pytorch#27978

-
ghstack-source-id: 92469187

Test Plan: waitforsandcastle

Differential Revision: D17929697

fbshipit-source-id: 01f4f67cd676c719d9d1fb13bdd43aca3dfa1c8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzhulgakov dzhulgakov dzhulgakov approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smessmer @ezyang @dzhulgakov @facebook-github-bot @mruberry