Skip to content

Conversation

@vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Oct 15, 2019

Documentation for learning rate does not render well. Fixes #27730.

Stack from ghstack:

Differential Revision: D17953395

Documentation for learning rate does not render well. #27730.
@vincentqb vincentqb changed the title fix docs for lr. fix docs for lr Oct 15, 2019
vincentqb added a commit that referenced this pull request Oct 15, 2019
ghstack-source-id: cd68595
Pull Request resolved: #28026
@zou3519
Copy link
Contributor

zou3519 commented Oct 15, 2019

Could you build the docs locally (via cd docs && make html && open build/html)and attach a screenshot of the updated page?

Documentation for learning rate does not render well. #27730.




[ghstack-poisoned]
vincentqb added a commit that referenced this pull request Oct 16, 2019
ghstack-source-id: 2cf96f3
Pull Request resolved: #28026
@vincentqb
Copy link
Contributor Author

Here's the output.

Screen Shot 2019-10-16 at 11 04 34 AM

Screen Shot 2019-10-16 at 11 09 42 AM

Unfortunately, there's not as much white space after the enumerated list as I would like. It's still much better than what was there before :)

@vincentqb vincentqb requested a review from zou3519 October 16, 2019 15:14
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to do about the space, but this lgtm

@facebook-github-bot
Copy link
Contributor

@vincentqb merged this pull request in cbddc77.

@facebook-github-bot facebook-github-bot deleted the gh/vincentqb/29/head branch October 28, 2019 22:21
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
Pull Request resolved: pytorch#28026

Documentation for learning rate does not render well. pytorch#27730.

Test Plan: Imported from OSS

Differential Revision: D17953395

Pulled By: vincentqb

fbshipit-source-id: 9e84df3e7de43f11399a67bc99c76ef241b1120f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants