Change dper3 loss module to match dper2 #28265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix the difference in dper3 and dper2 when regressionLoss is used. Test Plan: test using dper2 model id f134632386 Comparison tool output before change: ``` FOUND OP DIFFERENT WITH DPER2!!! OP is of type ExpandDims OP inputs ['supervision:label'] OP outputs ['sparse_nn/regression_loss/mean_squared_error_loss/ExpandDims:0'] =============================== Finished all dper3 ops, number of good ops 11, bad ops 1, skipped 26 run_comparison for dper2 / dper3 nets running time: 0.0020143985748291016 result type: <class 'NoneType'> result: None ``` After change: ``` FOUND OP DIFFERENT WITH DPER2!!! OP is of type ExpandDims OP inputs ['sparse_nn_2/regression_loss_2/mean_squared_error_loss_8/Squeeze:0_grad'] OP outputs ['sparse_nn_2/over_arch_2/linear_2/FC_grad'] =============================== Finished all dper3 ops, number of good ops 19, bad ops 1, skipped 16 run_comparison for dper2 / dper3 nets running time: 0.0017991065979003906 result type: <class 'NoneType'> result: None ``` dper2 label part of net P111794577 dper3 label part of net after change P116817194 Reviewed By: kennyhorror Differential Revision: D17795740 fbshipit-source-id: 2cc20dcc1b785a0f87d56e36e4f6a3eaac340fd3
|
This pull request was exported from Phabricator. Differential Revision: D17795740 |
|
This pull request has been merged in 46fefc9. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28265 Fix the difference in dper3 and dper2 when regressionLoss is used. Test Plan: test using dper2 model id f134632386 Comparison tool output before change: ``` FOUND OP DIFFERENT WITH DPER2!!! OP is of type ExpandDims OP inputs ['supervision:label'] OP outputs ['sparse_nn/regression_loss/mean_squared_error_loss/ExpandDims:0'] =============================== Finished all dper3 ops, number of good ops 11, bad ops 1, skipped 26 run_comparison for dper2 / dper3 nets running time: 0.0020143985748291016 result type: <class 'NoneType'> result: None ``` After change: ``` FOUND OP DIFFERENT WITH DPER2!!! OP is of type ExpandDims OP inputs ['sparse_nn_2/regression_loss_2/mean_squared_error_loss_8/Squeeze:0_grad'] OP outputs ['sparse_nn_2/over_arch_2/linear_2/FC_grad'] =============================== Finished all dper3 ops, number of good ops 19, bad ops 1, skipped 16 run_comparison for dper2 / dper3 nets running time: 0.0017991065979003906 result type: <class 'NoneType'> result: None ``` dper2 label part of net P111794577 dper3 label part of net after change P116817194 Reviewed By: kennyhorror Differential Revision: D17795740 fbshipit-source-id: 9faf96f5140f5a1efdf2985820bda3ca400f61fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix the difference in dper3 and dper2 when regressionLoss is used.
Test Plan:
test using dper2 model id f134632386
Comparison tool output before change:
After change:
dper2 label part of net P111794577
dper3 label part of net after change P116817194
Reviewed By: kennyhorror
Differential Revision: D17795740