-
Notifications
You must be signed in to change notification settings - Fork 25.7k
enable test_invalid_names test in rpc_test #28376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
|
|
|
@pytorchbot retest this please |
| from torch.distributed.rpc.api import _agent | ||
| self.assertEqual(_agent, None) | ||
| # join_rpc() should not do anything as _agent is None | ||
| rpc.join_rpc() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the join_rpc here if it doesn't do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's not necessary, just to make sure it's fine to call join_rpc() even if init failed.
|
Test failures are irrelevant, landing. |
This comment block was added in #28376 but the barrier has since gone away, so the comment does not seem necessary Differential Revision: [D18682506](https://our.internmc.facebook.com/intern/diff/D18682506/) [ghstack-poisoned]
This comment block was added in #28376 but the barrier has since gone away, so the comment does not seem necessary Differential Revision: [D18682506](https://our.internmc.facebook.com/intern/diff/D18682506/) ghstack-source-id: 94504139 Pull Request resolved: #30396
Summary: Pull Request resolved: pytorch#28376 Test Plan: Imported from OSS Differential Revision: D18045158 Pulled By: mrshenli fbshipit-source-id: 42821ef40afbdff8662abacd447e307ccf4853d3
Stack from ghstack:
Differential Revision: D18045158