Skip to content

Conversation

@mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Oct 21, 2019

Stack from ghstack:

Differential Revision: D18045158

mrshenli added a commit that referenced this pull request Oct 21, 2019
ghstack-source-id: 3614f13
Pull Request resolved: #28376

Fix test_invalid_names

ghstack-source-id: 3614f13
Pull Request resolved: #28377
@mrshenli
Copy link
Contributor Author

mrshenli commented Oct 21, 2019

Closing this PR as it is squashed into the previous one. Closed the wrong one.

@mrshenli mrshenli closed this Oct 21, 2019
@mrshenli mrshenli reopened this Oct 21, 2019
@mrshenli
Copy link
Contributor Author

@pytorchbot retest this please

from torch.distributed.rpc.api import _agent
self.assertEqual(_agent, None)
# join_rpc() should not do anything as _agent is None
rpc.join_rpc()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the join_rpc here if it doesn't do anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's not necessary, just to make sure it's fine to call join_rpc() even if init failed.

@mrshenli
Copy link
Contributor Author

Test failures are irrelevant, landing.

(core dumped) "$PYTHON" -m pytest -x -v --disable-warnings --junit-xml="$pytest_reports_dir/result.xml" --ignore "$caffe2_pypath/python/test/executor_test.py" --ignore "$caffe2_pypath/python/operator_test/matmul_op_test.py" --ignore "$caffe2_pypath/python/operator_test/pack_ops_test.py" --ignore "$caffe2_pypath/python/mkl/mkl_sbn_speed_test.py" ${rocm_ignore_test[@]} "$caffe2_pypath/python" "${EXTRA_TESTS[@]}"
Exited with code 134
20:56:56 ======================================================================
20:56:56 ERROR: test_download_url_to_file (__main__.TestHub)
20:56:56 ----------------------------------------------------------------------
20:56:56 Traceback (most recent call last):
20:56:56   File "C:\Jenkins\Miniconda3\lib\urllib\request.py", line 1318, in do_open
20:56:56     encode_chunked=req.has_header('Transfer-encoding'))
20:56:56   File "C:\Jenkins\Miniconda3\lib\http\client.py", line 1239, in request
20:56:56     self._send_request(method, url, body, headers, encode_chunked)
20:56:56   File "C:\Jenkins\Miniconda3\lib\http\client.py", line 1285, in _send_request
20:56:56     self.endheaders(body, encode_chunked=encode_chunked)
20:56:56   File "C:\Jenkins\Miniconda3\lib\http\client.py", line 1234, in endheaders
20:56:56     self._send_output(message_body, encode_chunked=encode_chunked)
20:56:56   File "C:\Jenkins\Miniconda3\lib\http\client.py", line 1026, in _send_output
20:56:56     self.send(msg)
20:56:56   File "C:\Jenkins\Miniconda3\lib\http\client.py", line 964, in send
20:56:56     self.connect()
20:56:56   File "C:\Jenkins\Miniconda3\lib\http\client.py", line 1400, in connect
20:56:56     server_hostname=server_hostname)
20:56:56   File "C:\Jenkins\Miniconda3\lib\ssl.py", line 407, in wrap_socket
20:56:56     _context=self, _session=session)
20:56:56   File "C:\Jenkins\Miniconda3\lib\ssl.py", line 817, in __init__
20:56:56     self.do_handshake()
20:56:56   File "C:\Jenkins\Miniconda3\lib\ssl.py", line 1077, in do_handshake
20:56:56     self._sslobj.do_handshake()
20:56:56   File "C:\Jenkins\Miniconda3\lib\ssl.py", line 689, in do_handshake
20:56:56     self._sslobj.do_handshake()
20:56:56 ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 0ddb500.

@pietern pietern added oncall: distributed Add this issue/PR to distributed oncall triage queue module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer labels Oct 22, 2019
@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/29/head branch October 28, 2019 22:17
rohan-varma added a commit that referenced this pull request Nov 25, 2019
This comment block was added in
#28376 but the barrier has since gone
away, so the comment does not seem necessary

Differential Revision: [D18682506](https://our.internmc.facebook.com/intern/diff/D18682506/)

[ghstack-poisoned]
rohan-varma added a commit that referenced this pull request Nov 25, 2019
This comment block was added in
#28376 but the barrier has since gone
away, so the comment does not seem necessary

Differential Revision: [D18682506](https://our.internmc.facebook.com/intern/diff/D18682506/)

ghstack-source-id: 94504139
Pull Request resolved: #30396
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary: Pull Request resolved: pytorch#28376

Test Plan: Imported from OSS

Differential Revision: D18045158

Pulled By: mrshenli

fbshipit-source-id: 42821ef40afbdff8662abacd447e307ccf4853d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants