Port is_set_to from TH/THC to ATen. #28425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
mruberry
reviewed
Oct 22, 2019
| return result.copy_(self); | ||
| } | ||
|
|
||
| bool is_set_to(const Tensor &self, const Tensor& src) { |
mruberry
reviewed
Oct 22, 2019
| self.storage_offset() == src.storage_offset() && | ||
| self.dim() == src.dim()) | ||
| { | ||
| for (int64_t d = 0; d < self.dim(); ++d) |
There was a problem hiding this comment.
for (auto d = decltype(self.dim()){0}; d < ...
mruberry
reviewed
Oct 22, 2019
| auto result = at::empty_like(self, self.options(), memory_format); | ||
| return result.copy_(self); | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this function need a comment? The name isn't super clear.
mruberry
reviewed
Oct 22, 2019
mruberry
reviewed
Oct 22, 2019
| for (int64_t d = 0; d < self.dim(); ++d) | ||
| { | ||
| if (self.size(d) != src.size(d) || self.stride(d) != src.stride(d)) { | ||
| return true; |
mruberry
requested changes
Oct 22, 2019
Differential Revision: [D18063328](https://our.internmc.facebook.com/intern/diff/D18063328) [ghstack-poisoned]
mruberry
approved these changes
Oct 22, 2019
Differential Revision: [D18063328](https://our.internmc.facebook.com/intern/diff/D18063328) [ghstack-poisoned]
This was referenced Oct 22, 2019
Differential Revision: [D18063328](https://our.internmc.facebook.com/intern/diff/D18063328) [ghstack-poisoned]
Differential Revision: [D18063328](https://our.internmc.facebook.com/intern/diff/D18063328) [ghstack-poisoned]
This was referenced Oct 23, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 24, 2019
Summary: Pull Request resolved: pytorch/pytorch#28425 Test Plan: Imported from OSS Differential Revision: D18063328 Pulled By: gchanan fbshipit-source-id: 86af01a630d88c30947b8c85d1fac86dd7b40585
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28425 Test Plan: Imported from OSS Differential Revision: D18063328 Pulled By: gchanan fbshipit-source-id: 86af01a630d88c30947b8c85d1fac86dd7b40585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18063328