separate PT and C2 to reduce build time #28731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D18152071 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D18152071 |
Summary: Pull Request resolved: #28731 as title Test Plan: ``` Before: buck run mode/opt caffe2/benchmarks/operator_benchmark:benchmark_all_test -- --operator sigmoid Action graph will be rebuilt because files have been added or removed. Building: finished in 02:19.5 min (100%) 7032/7032 jobs, 1 updated Total time: 02:20.0 min # ---------------------------------------- # PyTorch/Caffe2 Operator Micro-benchmarks # ---------------------------------------- # Tag : short # Benchmarking PyTorch: sigmoid # Mode: Eager # Name: sigmoid_M512_N512 # Input: M: 512, N: 512 Forward Execution Time (us) : 371.808 With this diff buck run mode/opt caffe2/benchmarks/operator_benchmark:benchmark_all_test -- --operator sigmoid Parsing buck files: finished in 0.9 sec Creating action graph: finished in 9.3 sec Building: finished in 7.1 sec (100%) 5287/5287 jobs, 4 updated Total time: 17.3 sec # ---------------------------------------- # PyTorch/Caffe2 Operator Micro-benchmarks # ---------------------------------------- # Tag : short # Benchmarking PyTorch: sigmoid # Mode: Eager # Name: sigmoid_M512_N512 # Input: M: 512, N: 512 Forward Execution Time (us) : 377.108 Reviewed By: hl475 Differential Revision: D18152071 fbshipit-source-id: c413158e291ebd3dfc97c27c70533a883b60ac88
|
This pull request was exported from Phabricator. Differential Revision: D18152071 |
|
This pull request has been merged in 9f44a04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as title
Test Plan: