Explain how to specify library location for MKL #28779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
reviewed
Oct 28, 2019
cmake/Modules/FindMKL.cmake
Outdated
| IF(NOT MKL_FOUND AND MKL_FIND_REQUIRED) | ||
| MESSAGE(FATAL_ERROR "MKL library not found. Please specify library location") | ||
| MESSAGE(FATAL_ERROR "MKL library not found. Please specify library location \ | ||
| by setting CMAKE_PREFIX_PATH to the root directory of the MKL installation.") |
There was a problem hiding this comment.
It might be better to mention that you should append the directory to CMAKE_PREFIX_PATH, in case someone already has directories listed there.
soumith
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 28, 2019
Summary: Fixes pytorch/pytorch#24334. I'm still kind of confused why `FindMKL.cmake` was unable to locate my MKL libraries. They are in the standard `/opt/intel/mkl` installation prefix on macOS. But at least with this more detailed error message, it will be easier for people to figure out how to fix the problem. zhangguanheng66 xkszltl soumith Pull Request resolved: pytorch/pytorch#28779 Differential Revision: D18170998 Pulled By: soumith fbshipit-source-id: 47e61baadd84c758267dca566eb1fb8a081de92f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24334.
I'm still kind of confused why
FindMKL.cmakewas unable to locate my MKL libraries. They are in the standard/opt/intel/mklinstallation prefix on macOS. But at least with this more detailed error message, it will be easier for people to figure out how to fix the problem.@zhangguanheng66 @xkszltl @soumith